User talk:Ilikenwf

recent edit re gl/gles

Are you certain about your recent edit to the kodi wiki page? I understood gles to be a subset of gl. Graysky (talk) 21:25, 16 December 2023 (UTC)

100% - it is indeed a subset but after reading this thread https://forum.kodi.tv/showthread.php?tid=375348 and trying a liveusb of Libreelec which builds with gles and plays HDR, and building kodi-git myself with it, I find that it does in fact play HDR properly. Very strange, very interesting. Been beating my head against this issue for a few weeks. Ilikenwf (talk) 21:27, 16 December 2023 (UTC)

Correction, these threads:

https://forum.kodi.tv/showthread.php?tid=372055

https://forum.kodi.tv/showthread.php?tid=371952 Ilikenwf (talk) 21:29, 16 December 2023 (UTC)

Oh, I just realized I tested this using a modified version of your AUR package. The only other thing I have going on is that in my case I merged a currently unmerged PR that makes more HDR content play back properly:

https://github.com/xbmc/xbmc/pull/24160 Ilikenwf (talk) 21:32, 16 December 2023 (UTC)

I created this thread just now, hopefully one of the devs will comment. I also did a test playing the file named HDR_HEVC_10-bit_BT.2020_59.940fps_Camp_by_Sony.mp4 available from the kodi samples wiki page. To my eye, the colors are more vivid on the gl compiled version, not the gles compiled version. Both advertise "Display supported HDR types: HDR10" under system info. How are you assessing HDR content as working or not working? Graysky (talk) 21:48, 16 December 2023 (UTC)

It isn't hard to detect HDR/HDR10 etc support as that is based on the monitor EDID. You're likely getting tone mapped video...you have to see if the display or tv you're playing on is actually in HDR mode or not. Under gl, the display does not switch to HDR mode.

For SDR videos I note that nothing has changed in quality, and that for HDR in my case, I'm actually seeing vivid colors. Another test is to take the current generic Libreelec build and live boot it, as it uses gles and plays HDR properly. Ilikenwf (talk) 21:51, 16 December 2023 (UTC)

I guess if it comes down to it we could have a -gles AUR package...I do have a PR in on the official package as well to use gles, but it would be nice to get to the bottom fo this. Ilikenwf (talk) 23:51, 16 December 2023 (UTC)

OK, so on my Samsung QN90B, my 4k appletv causes the tv to detect "UHD" and "HDR" when I display the info function but with kodi-gbm (either gl or gles) it only shows "UHD". Tested with kodi nexus but not omega. What is needed to have kodi-gbm/gles output to HDR? EDIT: I tried using LibreELEC-Generic.x86_64-11.0.3 live USB to play the same file but it too failed to render in HDR.

In my case having a tv that supports HDR10 and HLG, but hten make sure your HDMI port being used is in hdmi 2.0 or higher mode, as well. The "how" with each TV varies there. Otherwise this patch is something I've been building into mine to playback HDR more consistently in the case of bad metadata. https://github.com/xbmc/xbmc/pull/24160 Ilikenwf (talk) 18:52, 17 December 2023 (UTC)

Also note you'll only see HDR when kodi playing an HDR file - ensure that the hdr toggles are turned on in kodi's player and system/display settings too. Ilikenwf (talk) 18:55, 17 December 2023 (UTC)

I am aware that the mode changes upon playbck. HDR does work if I use my RPi4B using popcornmix's gbm_nexus fork using that test clip I mentioned above. I built kodi-gbm/gles on my x86-64 Arch box with that PR applied, but it failed to set the TV in HDR mode for playback. Since yours is playing HDR correctly, are you building nexus or omega? Have you confirmed that nexus works to playback HDR with that PR applied? Graysky (talk) 19:30, 17 December 2023 (UTC)

Omega, I have not attepted Nexus, last time I tried it I ran into issues.

I also did this last build with -DENABLE_INTERNAL_FFMPEG=OFF as it is the same flag used by Libreelec. I am not 100% sure this actually causes it to use the system ffmpeg, but I have these packages:

intel-gmmlib-git 22.3.15.r2.gf056c5d-1

intel-media-driver-git 2023.4.3.r27.g8b608aef2-1

kodi-addon-inputstream-adaptive-git 21.3.0.Omega.r37.ga7d0554-1

kodi-addon-pvr-iptvsimple-git r841.7b75a2d-1

kodi-git r64679.157ce50b167-1

kodi-git-dev r64679.157ce50b167-1

kodi-git-eventclients r64679.157ce50b167-1

kodi-git-tools-texturepacker r64679.157ce50b167-1

libva-git 2.20.0.r8.g63d2b223-1

libva-vdpau-driver-vp9-git r58.3d422a4-1

mesa-git 24.0.0_devel.181987.9ab59574ef1-1 Ilikenwf (talk) 19:33, 17 December 2023 (UTC)

ffmpeg-git 6.2.r112940.g1439784ff0-1 Ilikenwf (talk) 19:34, 17 December 2023 (UTC)

When you say "ensure that the hdr toggles are turned on in kodi's player and system/display settings too." what is the name of these settings? Graysky (talk) 19:37, 17 December 2023 (UTC)

Under settings/player (expert mode): "Adjust display HDR mode" - on Ilikenwf (talk) 19:39, 17 December 2023 (UTC)

I will need to build and test with omega... on nexus I have settings/player>videos>use display HDR capabilities enabled Graysky (talk) 19:41, 17 December 2023 (UTC)

That should do it but Omega may just have enough done to improve HDR support that it is best to use for it now...or in my particular setup aanyway, this combination may just be what works properly. Ilikenwf (talk) 19:42, 17 December 2023 (UTC)

Sorry for dragging you down the rabbit hole, I noticed the thread and your github issue. I use an Arc A380 and so I don't see the same bugs you do...actually my bugs are that VAAPI on the Arc for whatever reason can't playback streamed youtube HDR videos (CPU/software rendering can), but yet if I download them with yt-dlp, the hardware decoder can play them fine...so that's...fun. So is your bug...

But yeah sorry for dragging you into this, but Kodi 21 is on the verge of really being a big deal with HDR working properly...or even partially properly. Ilikenwf (talk) 09:01, 19 December 2023 (UTC)

It's fine. Helped to uncover what I believe is a bug. Either with my hardware or with Kodi itself. Graysky (talk) 11:45, 19 December 2023 (UTC)