User talk:LenHuppe/ZFS on Archiso/

From ArchWiki

ZFS script

I think you should carefully read the Archiso page again and give the Notes and Warnings extra attention.
For now this script is a potentially dangerous projectile to use and can crash your PC, using the rm's this way.

Also, remove line like the shellcheck one, it has no use, at all.
Remove 'cd' they are unnecessary .
Add 'zfs-dkms' to the 'pkg_add' array, it's just overhead to have an extra variable for that.
What is the use to add 'shellcheck' & 'vim-ale' to the 'pkg_add' array?

There are other things I don't agree to, but, the above are most important ones.
I don't mean to be rude, but I find other users should read this too, please change things;)

-- Qinohe (talk) 20:35, 04 July 2021 (Amsterdam)

edit: Thank you @LenHuppe, The script should now at least be save to use.
You may still wrap some things in a function, like the syslinux and efiboot part for it checks every line which is unnecessary if you kernel is 'linux'

-- Qinohe (talk) 18:22, 06 July 2021 (Amsterdam)