Talk:WebGrab+Plus

From ArchWiki
Jump to navigation Jump to search

Expansion

I am sorry to tell you that you shouldn't needlessly duplicate the upstream documentation.

--Larivact (talk) 12:05, 29 August 2018 (UTC)

Then please explain what do you expect from me?
I proactively created AUR package, described basic usage in Arch Wiki by creating this page, configuration and other details required to set it up and get it running. Then I find out the page was "Deleted" because it lacks of content and needs to be expanded. Fine - I expanded it by adding some content. Now you are telling me that it duplicates information from upstream web page.
Please tell me what needs to be done in order to make you happy regarding this page? Because for now it just feels like you don't have anything to do an just want to waste somebody's time.
-- Erkexzcx (talk) 12:17, 31 August 2018 (UTC)
Firstly, I suggest you to update your AUR package to directly symlink /opt/wg++/bin/WebGrab+Plus.exe to /usr/bin/wg++. Your convenience Bash script only unnecessarily hides complexity. --Larivact (talk) 14:35, 31 August 2018 (UTC)
And then every time run this mono /usr/bin/wg++ <config_dir>? I just updated it as per your recommendation, but please get familiar with this app before making any judges. It was not designed to be installed in the first place. -- Erkexzcx (talk) 15:18, 31 August 2018 (UTC)
You should be able to do wg++ config_dir. Mono executable can generally be executed directly, see Mono. I am sorry you feel that way, I'm just trying to improve the article ... --Larivact (talk) 15:29, 31 August 2018 (UTC)
If you'd actually remove your wrapper instead of making it more sophisticated, the article could look like this. --Larivact (talk) 15:34, 31 August 2018 (UTC)
Regarding Mono - I've been testing this a lot with nbfc-gitAUR and it did not work. Well, it worked once as long as I remember, but when I put into shell script - it worked fantastically every time.
Alright I'm no Mono expert. I'd still prefer a script with just mono /opt/wg++/bin/WebGrab+Plus.exe "$@". --Larivact (talk) 15:44, 31 August 2018 (UTC)
I've updated AUR package wg++AUR with way better wrapping script wg++. If you want, feel free to update arch wiki page regarding your wg++ <path> usage. Also feel free to check wrapping script - maybe this is not what you wanted, but keeping it the way developer intended it to be makes no sense to have AUR package in the first place, because user can simply download archived folder itself and run directly from it. -- Erkexzcx (talk) 14:10, 2 September 2018 (UTC)
It's Arch's philosophy to only have minimal changes to upstream, see Arch Linux#Simplicity. --Larivact (talk) 14:26, 2 September 2018 (UTC)

Going forward

As long as current documentation is useful - I am more than happy. For now - it looks great. Few things to point out:

  • How are you planning to make it work with systemd?
  • Did you know that it generates WebGrab++.log.txt in working directory and while it's running - generates extra folder and deletes when finishes? How do you think systemd service/timer handles this?
  • Give me an example how can it be implemented with systemd? Going forward - probably AUR needs to changed, but as I stated earlier - this app was not designed to be installable. Any tips?

—This unsigned comment is by Erkexzcx (talk) 15:37, 31 August 2018‎. Please sign your posts with ~~~~!

I don't think the package needs a service, if users want a timer they can create it themselves. systemd has a WorkingDirectory option. --Larivact (talk) 15:40, 31 August 2018 (UTC)